[Rpcemu] Patch for 0.9.1 - Mac keyboard support

Theo Markettos theo at markettos.org.uk
Mon Nov 19 13:49:16 PST 2018


On Mon, Nov 19, 2018 at 07:43:18PM +0000, Timothy Coltman wrote:
> Hello all
> 
> Please find attached a ZIP archive (169K) containing a patch for RPCEmu
> 0.9.1 that implements keyboard support for OS X/macOS.  The file contains
> a patch in unified diff format ("rpcemu-0.9.1-mac-v1.patch") plus a folder
> ("macosx") containing the icons for the Mac's dock.  This should be
> unpacked in the "src" folder and the patch applied from there.

That's great.  It looked so good until I came across the Qt keyboard
problem, so fixing that should improve the RPCEmu Mac experience a lot.

> 4. The patch uses virtual key codes and assumes a UK keyboard layout. 
> There is support for other keyboard layouts, but needs these to be defined
> in the "keyboard_macosx.c" file (there is a very basic French layout
> defined that swaps "Y" and "Z").

I've had no end of problems with things getting keyboard layouts wrong on
MacOS (usually with remote connections to other machines where the other end
is set differently) so it wouldn't be the first time.

Does your layout handle US keyboards (it's usually \|~`#@" that get
into trouble)?

I usually use the 'British PC' layout on a Macbook Pro which is additional
fun because the keys are now moved around compared to the Apple layout.

> Please note that there is no networking support.  I did try and get it up
> and running, using some of the code from the "Caliston" builds of Francis
> Devereux and whilst it did look promising at one point (I could ping from
> one end), I wasn't able to get it to work fully.

Those are my builds, and I never got networking to play nicely.
I wonder whether, instead of using TUN/TAP, on MacOS it might be worth
investigating NETunnelProvider as a native API for networking?
https://developer.apple.com/documentation/networkextension
That would make a much nicer user experience.

> Any comments and suggestions would be appreciated.  If anyone wants
> binaries (so they don't have to compile), please let me know and I'll make
> some available in due course.

Peter may have other opinions, but AIUI he doesn't have any means of
producing Mac builds.  It sounds like you're set up to do that, so you could
take over producing them from me - I didn't have any special infrastructure
for that beyond a very hacked up Xcode with Snow Leopard libraries - I was
just making random builds on my laptop from time to time.  (and running any
kind of CI with MacOS is a pain, so they're not straightforward to automate)

Theo



More information about the RPCEmu mailing list